Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(bazel): add MODULE.bazel files for bzlmod #1754

Merged
merged 1 commit into from
May 8, 2024

Conversation

mmorel-35
Copy link
Contributor

This provide a MODULE.bazel to be compatible with bzlmod
See Bzlmod Migration Guide for more information

Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
@mmorel-35
Copy link
Contributor Author

mmorel-35 commented May 8, 2024

Hi @galabovaa, @Mizux,

#1751 got unexpectedly closed, this recreate it.

It includes the requested modifications.

@galabovaa galabovaa self-requested a review May 8, 2024 07:51
Copy link
Contributor

@Mizux Mizux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (Looks Good To Me)

only the bcr.1 stuff for zlib, I trust you ;)

@galabovaa galabovaa merged commit 96c3dd2 into ERGO-Code:latest May 8, 2024
@mmorel-35 mmorel-35 deleted the bzlmod branch May 8, 2024 13:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants